Commit 75e406b5 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Hans de Goede
Browse files

platform/x86/intel-uncore-freq: Return error on write frequency 



Currently when the uncore_write() returns error, it is silently
ignored. Return error to user space when uncore_write() fails.

Fixes: 49a474c7 ("platform/x86: Add support for Uncore frequency control")
Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Reviewed-by: default avatarZhang Rui <rui.zhang@intel.com>
Tested-by: default avatarWendy Wang <wendy.wang@intel.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230418153230.679094-1-srinivas.pandruvada@linux.intel.com


Cc: stable@vger.kernel.org
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 4a9b6850

drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c

+5 −1
Original line number Diff line number Diff line
@@ -44,14 +44,18 @@ static ssize_t store_min_max_freq_khz(struct uncore_data *data, 
				      int min_max)

{

	unsigned int input;

	int ret;



	if (kstrtouint(buf, 10, &input))

		return -EINVAL;



	mutex_lock(&uncore_lock);

	uncore_write(data, input, min_max);

	ret = uncore_write(data, input, min_max);

	mutex_unlock(&uncore_lock);



	if (ret)

		return ret;



	return count;

}