Commit 75e13a76 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Jonathan Cameron
Browse files

iio: imu: inv_mpu6050: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarJean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Link: https://lore.kernel.org/r/20200829064726.26268-13-krzk@kernel.org


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent a567abf6

drivers/iio/imu/inv_mpu6050/inv_mpu_core.c

+6 −14
Original line number Diff line number Diff line
@@ -1475,22 +1475,14 @@ int inv_mpu_core_probe(struct regmap *regmap, int irq, const char *name, 
	}



	st->vdd_supply = devm_regulator_get(dev, "vdd");

	if (IS_ERR(st->vdd_supply)) {

		if (PTR_ERR(st->vdd_supply) != -EPROBE_DEFER)

			dev_err(dev, "Failed to get vdd regulator %d\n",

				(int)PTR_ERR(st->vdd_supply));



		return PTR_ERR(st->vdd_supply);

	}

	if (IS_ERR(st->vdd_supply))

		return dev_err_probe(dev, PTR_ERR(st->vdd_supply),

				     "Failed to get vdd regulator\n");



	st->vddio_supply = devm_regulator_get(dev, "vddio");

	if (IS_ERR(st->vddio_supply)) {

		if (PTR_ERR(st->vddio_supply) != -EPROBE_DEFER)

			dev_err(dev, "Failed to get vddio regulator %d\n",

				(int)PTR_ERR(st->vddio_supply));



		return PTR_ERR(st->vddio_supply);

	}

	if (IS_ERR(st->vddio_supply))

		return dev_err_probe(dev, PTR_ERR(st->vddio_supply),

				     "Failed to get vddio regulator\n");



	result = regulator_enable(st->vdd_supply);

	if (result) {