Commit 75c19f48 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

usb: host: ehci-sched: Use struct_size() in kzalloc() 

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worse scenario, could lead to heap overflows.

Also, address the following sparse warning:
drivers/usb/host/ehci-sched.c:1168:40: warning: using sizeof on a flexible structure

Link: https://github.com/KSPP/linux/issues/160
Link: https://github.com/KSPP/linux/issues/174


Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20220111075427.GA76390@embeddedor


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e783362e

drivers/usb/host/ehci-sched.c

+1 −3
Original line number Diff line number Diff line
@@ -1165,10 +1165,8 @@ static struct ehci_iso_sched * 
iso_sched_alloc(unsigned packets, gfp_t mem_flags)

{

	struct ehci_iso_sched	*iso_sched;

	int			size = sizeof(*iso_sched);



	size += packets * sizeof(struct ehci_iso_packet);

	iso_sched = kzalloc(size, mem_flags);

	iso_sched = kzalloc(struct_size(iso_sched, packet, packets), mem_flags);

	if (likely(iso_sched != NULL))

		INIT_LIST_HEAD(&iso_sched->td_list);