Commit 75b62ab6 authored by Jonas Witschel's avatar Jonas Witschel Committed by Takashi Iwai
Browse files

ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G7 

The HP ProBook 445 G7 (17T32ES) uses ALC236. Like ALC236_FIXUP_HP_GPIO_LED,
COEF index 0x34 bit 5 is used to control the playback mute LED, but the
microphone mute LED is controlled using pin VREF instead of a COEF index.

AlsaInfo: https://alsa-project.org/db/?f=0d3f4d1af39cc359f9fea9b550727ee87e5cf45a


Signed-off-by: default avatarJonas Witschel <diabonas@archlinux.org>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210416105852.52588-1-diabonas@archlinux.org


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 26928ca1

sound/pci/hda/patch_realtek.c

+25 −0
Original line number Diff line number Diff line
@@ -4445,6 +4445,25 @@ static void alc236_fixup_hp_mute_led(struct hda_codec *codec, 
	alc236_fixup_hp_coef_micmute_led(codec, fix, action);

}



static void alc236_fixup_hp_micmute_led_vref(struct hda_codec *codec,

				const struct hda_fixup *fix, int action)

{

	struct alc_spec *spec = codec->spec;



	if (action == HDA_FIXUP_ACT_PRE_PROBE) {

		spec->cap_mute_led_nid = 0x1a;

		snd_hda_gen_add_micmute_led_cdev(codec, vref_micmute_led_set);

		codec->power_filter = led_power_filter;

	}

}



static void alc236_fixup_hp_mute_led_micmute_vref(struct hda_codec *codec,

				const struct hda_fixup *fix, int action)

{

	alc236_fixup_hp_mute_led_coefbit(codec, fix, action);

	alc236_fixup_hp_micmute_led_vref(codec, fix, action);

}



#if IS_REACHABLE(CONFIG_INPUT)

static void gpio2_mic_hotkey_event(struct hda_codec *codec,

				   struct hda_jack_callback *event)
@@ -6410,6 +6429,7 @@ enum { 
	ALC285_FIXUP_HP_MUTE_LED,

	ALC236_FIXUP_HP_GPIO_LED,

	ALC236_FIXUP_HP_MUTE_LED,

	ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF,

	ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET,

	ALC295_FIXUP_ASUS_MIC_NO_PRESENCE,

	ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS,
@@ -7669,6 +7689,10 @@ static const struct hda_fixup alc269_fixups[] = { 
		.type = HDA_FIXUP_FUNC,

		.v.func = alc236_fixup_hp_mute_led,

	},

	[ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc236_fixup_hp_mute_led_micmute_vref,

	},

	[ALC298_FIXUP_SAMSUNG_HEADPHONE_VERY_QUIET] = {

		.type = HDA_FIXUP_VERBS,

		.v.verbs = (const struct hda_verb[]) {
@@ -8092,6 +8116,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x8730, "HP ProBook 445 G7", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),

	SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_AMP_INIT),

	SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),