Commit 75a206fa authored Jun 15, 2023 by JiangShui Yang Committed by openeuler-sync-bot Jun 21, 2023

crypto: hisilicon/qm: modify loop exit condition

driver inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7DUYJ


CVE: NA

----------------------------------------------------------------------

Loop branch using 'i++' as condition will cause the loop to not execute
when 'i == 0', should use '++i', Fix it.

Fixes: 26f2f10d ("crypto: hisilicon/qm - obtain the mailbox
configuration at one time")
Fixes: aabdf15d ("vfio/migration: obtain the mailbox configuration at one
time")
Signed-off-by: JiangShui Yang <yangjiangshui@h-partners.com>
Signed-off-by: Weili Qian <qianweili@huawei.com>
(cherry picked from commit fc71ef55)

parent 420dcdfd

drivers/crypto/hisilicon/migration/acc_vf_migration.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -104,7 +104,7 @@ static int qm_wait_mb_finish(struct hisi_qm qm, struct qm_mailbox mailbox)
		{
		int i = 0;

		while (i++) {
		while (++i) {
		qm_mb_read(qm, mailbox);
		if (!((le16_to_cpu(mailbox->w0) >> QM_MB_BUSY_SHIFT) & 0x1))
		break;

drivers/crypto/hisilicon/qm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -667,7 +667,7 @@ static int qm_wait_mb_finish(struct hisi_qm qm, struct qm_mailbox mailbox)
		{
		int i = 0;

		while (i++) {
		while (++i) {
		qm_mb_read(qm, mailbox);
		if (!((le16_to_cpu(mailbox->w0) >> QM_MB_BUSY_SHIFT) & 0x1))
		break;