Commit 759fcaaf authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

usb: typec: stusb160x: Switch to use dev_err_probe() helper 



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20220922135228.2206755-1-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3fbfcf0c

drivers/usb/typec/stusb160x.c

+2 −5
Original line number Diff line number Diff line
@@ -750,11 +750,8 @@ static int stusb160x_probe(struct i2c_client *client) 
	if (client->irq) {

		chip->role_sw = fwnode_usb_role_switch_get(fwnode);

		if (IS_ERR(chip->role_sw)) {

			ret = PTR_ERR(chip->role_sw);

			if (ret != -EPROBE_DEFER)

				dev_err(chip->dev,

					"Failed to get usb role switch: %d\n",

					ret);

			ret = dev_err_probe(chip->dev, PTR_ERR(chip->role_sw),

					    "Failed to get usb role switch\n");

			goto port_unregister;

		}