Commit 7599b70a authored by Timothy Hayes's avatar Timothy Hayes Committed by Arnaldo Carvalho de Melo
Browse files

perf arm-spe: Fix SPE events with phys addresses 



This patch corrects a bug whereby SPE collection is invoked with
pa_enable=1 but synthesized events fail to show physical addresses.

Reviewed-by: default avatarLeo Yan <leo.yan@linaro.org>
Signed-off-by: default avatarTimothy Hayes <timothy.hayes@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Fastabend <john.fastabend@gmail.com>
Cc: John Garry <john.garry@huawei.com>
Cc: KP Singh <kpsingh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Martin KaFai Lau <kafai@fb.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Song Liu <songliubraving@fb.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yonghong Song <yhs@fb.com>
Cc: bpf@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: netdev@vger.kernel.org
Link: https://lore.kernel.org/r/20220421165205.117662-3-timothy.hayes@arm.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 4e13f670

tools/perf/arch/arm64/util/arm-spe.c

+10 −0
Original line number Diff line number Diff line
@@ -148,6 +148,7 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, 
	bool privileged = perf_event_paranoid_check(-1);

	struct evsel *tracking_evsel;

	int err;

	u64 bit;



	sper->evlist = evlist;
@@ -245,6 +246,15 @@ static int arm_spe_recording_options(struct auxtrace_record *itr, 
	 */

	evsel__set_sample_bit(arm_spe_evsel, DATA_SRC);



	/*

	 * The PHYS_ADDR flag does not affect the driver behaviour, it is used to

	 * inform that the resulting output's SPE samples contain physical addresses

	 * where applicable.

	 */

	bit = perf_pmu__format_bits(&arm_spe_pmu->format, "pa_enable");

	if (arm_spe_evsel->core.attr.config & bit)

		evsel__set_sample_bit(arm_spe_evsel, PHYS_ADDR);



	/* Add dummy event to keep tracking */

	err = parse_events(evlist, "dummy:u", NULL);

	if (err)

tools/perf/util/arm-spe.c

+2 −1
Original line number Diff line number Diff line
@@ -1033,7 +1033,8 @@ arm_spe_synth_events(struct arm_spe *spe, struct perf_session *session) 
	memset(&attr, 0, sizeof(struct perf_event_attr));

	attr.size = sizeof(struct perf_event_attr);

	attr.type = PERF_TYPE_HARDWARE;

	attr.sample_type = evsel->core.attr.sample_type & PERF_SAMPLE_MASK;

	attr.sample_type = evsel->core.attr.sample_type &

				(PERF_SAMPLE_MASK | PERF_SAMPLE_PHYS_ADDR);

	attr.sample_type |= PERF_SAMPLE_IP | PERF_SAMPLE_TID |

			    PERF_SAMPLE_PERIOD | PERF_SAMPLE_DATA_SRC |

			    PERF_SAMPLE_WEIGHT | PERF_SAMPLE_ADDR;