Commit 7587f8a8 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: sun4i: Don't check the return code of pwmchip_remove() 



pwmchip_remove() returns always 0. Don't use the value to make it
possible to eventually change the function to return void. Also the
driver core ignores the return value of sun4i_pwm_remove()
and considers the device removed anyhow. So returning early results
in a resource leak.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent ceb2c284

drivers/pwm/pwm-sun4i.c

+1 −4
Original line number Diff line number Diff line
@@ -484,11 +484,8 @@ static int sun4i_pwm_probe(struct platform_device *pdev) 
static int sun4i_pwm_remove(struct platform_device *pdev)

{

	struct sun4i_pwm_chip *pwm = platform_get_drvdata(pdev);

	int ret;



	ret = pwmchip_remove(&pwm->chip);

	if (ret)

		return ret;

	pwmchip_remove(&pwm->chip);



	clk_disable_unprepare(pwm->bus_clk);

	reset_control_assert(pwm->rst);