Commit 75751c80 authored by Jeb Cramer's avatar Jeb Cramer Committed by Tony Nguyen
Browse files

ice: Limit forced overrides based on FW version 



Beyond a specific version of firmware, there is no need to provide
override values to the firmware when setting PHY capabilities.  In this
case, we do not need to indicate whether we're in Strict or Lenient Link
Mode.

In the case of translating capabilities to the configuration structure,
the module compliance enforcement is already correctly set by firmware,
so the extra code block is redundant.

Signed-off-by: default avatarJeb Cramer <jeb.j.cramer@intel.com>
Tested-by: default avatarTony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 0a02944f

drivers/net/ethernet/intel/ice/ice_common.c

+2 −12
Original line number Diff line number Diff line
@@ -3013,17 +3013,6 @@ ice_copy_phy_caps_to_cfg(struct ice_port_info *pi, 
	cfg->link_fec_opt = caps->link_fec_options;

	cfg->module_compliance_enforcement =

		caps->module_compliance_enforcement;



	if (ice_fw_supports_link_override(pi->hw)) {

		struct ice_link_default_override_tlv tlv;



		if (ice_get_link_default_override(&tlv, pi))

			return;



		if (tlv.options & ICE_LINK_OVERRIDE_STRICT_MODE)

			cfg->module_compliance_enforcement |=

				ICE_LINK_OVERRIDE_STRICT_MODE;

	}

}



/**
@@ -3091,7 +3080,8 @@ ice_cfg_phy_fec(struct ice_port_info *pi, struct ice_aqc_set_phy_cfg_data *cfg, 
		break;

	}



	if (fec == ICE_FEC_AUTO && ice_fw_supports_link_override(pi->hw)) {

	if (fec == ICE_FEC_AUTO && ice_fw_supports_link_override(hw) &&

	    !ice_fw_supports_report_dflt_cfg(hw)) {

		struct ice_link_default_override_tlv tlv;



		if (ice_get_link_default_override(&tlv, pi))