Commit 7574fcdb authored by Xiaoming Ni's avatar Xiaoming Ni Committed by David S. Miller
Browse files

nfc: fix memory leak in llcp_sock_connect() 



In llcp_sock_connect(), use kmemdup to allocate memory for
 "llcp_sock->service_name". The memory is not released in the sock_unlink
label of the subsequent failure branch.
As a result, memory leakage occurs.

fix CVE-2020-25672

Fixes: d646960f ("NFC: Initial LLCP support")
Reported-by: default avatar"kiyin(尹亮)" <kiyin@tencent.com>
Link: https://www.openwall.com/lists/oss-security/2020/11/01/1


Cc: <stable@vger.kernel.org> #v3.3
Signed-off-by: default avatarXiaoming Ni <nixiaoming@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8a4cd82d

net/nfc/llcp_sock.c

+2 −0
Original line number Diff line number Diff line
@@ -746,6 +746,8 @@ static int llcp_sock_connect(struct socket *sock, struct sockaddr *_addr, 


sock_unlink:

	nfc_llcp_sock_unlink(&local->connecting_sockets, sk);

	kfree(llcp_sock->service_name);

	llcp_sock->service_name = NULL;



sock_llcp_release:

	nfc_llcp_put_ssap(local, llcp_sock->ssap);