Commit 756c52c6 authored by Cédric Le Goater's avatar Cédric Le Goater Committed by Michael Ellerman
Browse files

powerpc/xive: Activate StoreEOI on P10 



StoreEOI (the capability to EOI with a store) requires load-after-store
ordering in some cases to be reliable. P10 introduced a new offset for
load operations to enforce correct ordering and the XIVE driver has
the required support since kernel 5.8, commit b1f9be93
("powerpc/xive: Enforce load-after-store ordering when StoreEOI is active")

Since skiboot v7, StoreEOI support is advertised on P10 with a new flag
on the PowerNV platform. See skiboot commit 4bd7d84afe46 ("xive/p10:
Introduce a new OPAL_XIVE_IRQ_STORE_EOI2 flag"). When detected,
activate the feature.

Signed-off-by: default avatarCédric Le Goater <clg@kaod.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211105102636.1016378-4-clg@kaod.org
parent bd5b00c6

arch/powerpc/include/asm/opal-api.h

+1 −0
Original line number Diff line number Diff line
@@ -1094,6 +1094,7 @@ enum { 
	OPAL_XIVE_IRQ_SHIFT_BUG		= 0x00000008, /* P9 DD1.0 workaround */

	OPAL_XIVE_IRQ_MASK_VIA_FW	= 0x00000010, /* P9 DD1.0 workaround */

	OPAL_XIVE_IRQ_EOI_VIA_FW	= 0x00000020, /* P9 DD1.0 workaround */

	OPAL_XIVE_IRQ_STORE_EOI2	= 0x00000040,

};



/* Flags for OPAL_XIVE_GET/SET_QUEUE_INFO */

arch/powerpc/sysdev/xive/native.c

+2 −0
Original line number Diff line number Diff line
@@ -63,6 +63,8 @@ int xive_native_populate_irq_data(u32 hw_irq, struct xive_irq_data *data) 
	opal_flags = be64_to_cpu(flags);

	if (opal_flags & OPAL_XIVE_IRQ_STORE_EOI)

		data->flags |= XIVE_IRQ_FLAG_STORE_EOI;

	if (opal_flags & OPAL_XIVE_IRQ_STORE_EOI2)

		data->flags |= XIVE_IRQ_FLAG_STORE_EOI;

	if (opal_flags & OPAL_XIVE_IRQ_LSI)

		data->flags |= XIVE_IRQ_FLAG_LSI;

	data->eoi_page = be64_to_cpu(eoi_page);