Commit 75089d2e authored by Eduard Zingerman's avatar Eduard Zingerman Committed by Ma Wupeng
Browse files

selftests/bpf: dummy_st_ops should reject 0 for non-nullable params 

stable inclusion
from stable-v6.6.39
commit e7d193073a223663612301c659e53795b991ca89
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAD6H2

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e7d193073a223663612301c659e53795b991ca89



--------------------------------

[ Upstream commit 6a2d30d3c5bf9f088dcfd5f3746b04d84f2fab83 ]

Check if BPF_PROG_TEST_RUN for bpf_dummy_struct_ops programs
rejects execution if NULL is passed for non-nullable parameter.

Signed-off-by: default avatarEduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/r/20240424012821.595216-6-eddyz87@gmail.com


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarWang Hai <wanghai38@huawei.com>
parent d31b2989

tools/testing/selftests/bpf/prog_tests/dummy_st_ops.c

+27 −0
Original line number Diff line number Diff line
@@ -147,6 +147,31 @@ static void test_dummy_sleepable(void) 
	dummy_st_ops_success__destroy(skel);

}



/* dummy_st_ops.test_sleepable() parameter is not marked as nullable,

 * thus bpf_prog_test_run_opts() below should be rejected as it tries

 * to pass NULL for this parameter.

 */

static void test_dummy_sleepable_reject_null(void)

{

	__u64 args[1] = {0};

	LIBBPF_OPTS(bpf_test_run_opts, attr,

		.ctx_in = args,

		.ctx_size_in = sizeof(args),

	);

	struct dummy_st_ops_success *skel;

	int fd, err;



	skel = dummy_st_ops_success__open_and_load();

	if (!ASSERT_OK_PTR(skel, "dummy_st_ops_load"))

		return;



	fd = bpf_program__fd(skel->progs.test_sleepable);

	err = bpf_prog_test_run_opts(fd, &attr);

	ASSERT_EQ(err, -EINVAL, "test_run");



	dummy_st_ops_success__destroy(skel);

}



void test_dummy_st_ops(void)

{

	if (test__start_subtest("dummy_st_ops_attach"))
@@ -159,6 +184,8 @@ void test_dummy_st_ops(void) 
		test_dummy_multiple_args();

	if (test__start_subtest("dummy_sleepable"))

		test_dummy_sleepable();

	if (test__start_subtest("dummy_sleepable_reject_null"))

		test_dummy_sleepable_reject_null();



	RUN_TESTS(dummy_st_ops_fail);

}