Commit 74e3f6e6 authored by Arvind Yadav's avatar Arvind Yadav Committed by Helge Deller
Browse files

parisc: perf: Fix potential NULL pointer dereference 



Fix potential NULL pointer dereference and clean up
coding style errors (code indent, trailing whitespaces).

Signed-off-by: default avatarArvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 186ecf14

arch/parisc/kernel/perf.c

+49 −45
Original line number Diff line number Diff line
@@ -195,8 +195,8 @@ static int perf_config(uint32_t *image_ptr); 
static int perf_release(struct inode *inode, struct file *file);

static int perf_open(struct inode *inode, struct file *file);

static ssize_t perf_read(struct file *file, char __user *buf, size_t cnt, loff_t *ppos);

static ssize_t perf_write(struct file *file, const char __user *buf, size_t count, 

	loff_t *ppos);

static ssize_t perf_write(struct file *file, const char __user *buf,

	size_t count, loff_t *ppos);

static long perf_ioctl(struct file *file, unsigned int cmd, unsigned long arg);

static void perf_start_counters(void);

static int perf_stop_counters(uint32_t *raddr);
@@ -298,8 +298,8 @@ static ssize_t perf_read(struct file *file, char __user *buf, size_t cnt, loff_t 
 * called on the processor that the download should happen

 * on.

 */

static ssize_t perf_write(struct file *file, const char __user *buf, size_t count, 

	loff_t *ppos)

static ssize_t perf_write(struct file *file, const char __user *buf,

	size_t count, loff_t *ppos)

{

	size_t image_size;

	uint32_t image_type;
@@ -808,6 +808,10 @@ static int perf_write_image(uint64_t *memaddr) 
	}



	runway = ioremap_nocache(cpu_device->hpa.start, 4096);

	if (!runway) {

		pr_err("perf_write_image: ioremap failed!\n");

		return -ENOMEM;

	}



	/* Merge intrigue bits into Runway STATUS 0 */

	tmp64 = __raw_readq(runway + RUNWAY_STATUS) & 0xffecfffffffffffful;