Commit 74deef03 authored by Kai-Heng Feng's avatar Kai-Heng Feng Committed by Alex Deucher
Browse files

efifb: Check efifb_pci_dev before using it 

On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb is not
a PCI device.

So make sure efifb_pci_dev is found before using it.

Fixes: a6c0fd3d ("efifb: Ensure graphics device for efifb stays at PCI D0")
BugLink: https://bugs.launchpad.net/bugs/1922403


Signed-off-by: default avatarKai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210413170508.968148-1-kai.heng.feng@canonical.com
parent 2a269ba8

drivers/video/fbdev/efifb.c

+4 −2
Original line number Diff line number Diff line
@@ -575,6 +575,7 @@ static int efifb_probe(struct platform_device *dev) 
		goto err_fb_dealoc;

	}

	fb_info(info, "%s frame buffer device\n", info->fix.id);

	if (efifb_pci_dev)

		pm_runtime_get_sync(&efifb_pci_dev->dev);

	return 0;
@@ -602,6 +603,7 @@ static int efifb_remove(struct platform_device *pdev) 
	unregister_framebuffer(info);

	sysfs_remove_groups(&pdev->dev.kobj, efifb_groups);

	framebuffer_release(info);

	if (efifb_pci_dev)

		pm_runtime_put(&efifb_pci_dev->dev);



	return 0;