Commit 74a3bc42 authored by Wan Jiabing's avatar Wan Jiabing Committed by David S. Miller
Browse files

net: mscc: ocelot: Fix dumplicated argument in ocelot 



Fix the following coccicheck warning:
drivers/net/ethernet/mscc/ocelot.c:474:duplicated argument to & or |
drivers/net/ethernet/mscc/ocelot.c:476:duplicated argument to & or |
drivers/net/ethernet/mscc/ocelot_net.c:1627:duplicated argument
to & or |

These DEV_CLOCK_CFG_MAC_TX_RST are duplicate here.
Here should be DEV_CLOCK_CFG_MAC_RX_RST.

Fixes: e6e12df6 ("net: mscc: ocelot: convert to phylink")
Signed-off-by: default avatarWan Jiabing <wanjiabing@vivo.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0edf0824

drivers/net/ethernet/mscc/ocelot.c

+2 −2
Original line number Diff line number Diff line
@@ -472,9 +472,9 @@ void ocelot_phylink_mac_link_down(struct ocelot *ocelot, int port, 
	    !(quirks & OCELOT_QUIRK_QSGMII_PORTS_MUST_BE_UP))

		ocelot_port_rmwl(ocelot_port,

				 DEV_CLOCK_CFG_MAC_TX_RST |

				 DEV_CLOCK_CFG_MAC_TX_RST,

				 DEV_CLOCK_CFG_MAC_RX_RST,

				 DEV_CLOCK_CFG_MAC_TX_RST |

				 DEV_CLOCK_CFG_MAC_TX_RST,

				 DEV_CLOCK_CFG_MAC_RX_RST,

				 DEV_CLOCK_CFG);

}

EXPORT_SYMBOL_GPL(ocelot_phylink_mac_link_down);

drivers/net/ethernet/mscc/ocelot_net.c

+1 −1
Original line number Diff line number Diff line
@@ -1625,7 +1625,7 @@ static int ocelot_port_phylink_create(struct ocelot *ocelot, int port, 
	if (phy_mode == PHY_INTERFACE_MODE_QSGMII)

		ocelot_port_rmwl(ocelot_port, 0,

				 DEV_CLOCK_CFG_MAC_TX_RST |

				 DEV_CLOCK_CFG_MAC_TX_RST,

				 DEV_CLOCK_CFG_MAC_RX_RST,

				 DEV_CLOCK_CFG);



	ocelot_port->phy_mode = phy_mode;