Commit 74829ddf authored Jul 08, 2022 by David Gow Committed by Shuah Khan Jul 11, 2022

module: panic: Taint the kernel when selftest modules load



Taint the kernel with TAINT_TEST whenever a test module loads, by adding
a new "TEST" module property, and setting it for all modules in the
tools/testing directory. This property can also be set manually, for
tests which live outside the tools/testing directory with:
MODULE_INFO(test, "Y");

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Aaron Tomlin <atomlin@redhat.com>
Acked-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

parent 77ce8ba3

kernel/module/main.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1988,6 +1988,13 @@ static int check_modinfo(struct module mod, struct load_info info, int flags)
		/* Set up license info based on the info section */
		set_license(mod, get_modinfo(info, "license"));

		if (get_modinfo(info, "test")) {
		if (!test_taint(TAINT_TEST))
		pr_warn("%s: loading test module taints kernel.\n",
		mod->name);
		add_taint_module(mod, TAINT_TEST, LOCKDEP_STILL_OK);
		}

		return 0;
		}

scripts/mod/modpost.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -2191,6 +2191,9 @@ static void add_header(struct buffer b, struct module mod)

		if (strstarts(mod->name, "drivers/staging"))
		buf_printf(b, "\nMODULE_INFO(staging, \"Y\");\n");

		if (strstarts(mod->name, "tools/testing"))
		buf_printf(b, "\nMODULE_INFO(test, \"Y\");\n");
		}

		static void add_exported_symbols(struct buffer buf, struct module mod)