Commit 7471e1af authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring: include cflags in completion trace event 



We should be including the completion flags for better introspection on
exactly what completion event was logged.

Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 6c2450ae

fs/io_uring.c

+1 −1
Original line number Diff line number Diff line
@@ -1507,7 +1507,7 @@ static void __io_cqring_fill_event(struct io_kiocb *req, long res, 
	struct io_ring_ctx *ctx = req->ctx;

	struct io_uring_cqe *cqe;



	trace_io_uring_complete(ctx, req->user_data, res);

	trace_io_uring_complete(ctx, req->user_data, res, cflags);



	/*

	 * If we can't get a cq entry, userspace overflowed the

include/trace/events/io_uring.h

+7 −4
Original line number Diff line number Diff line
@@ -290,29 +290,32 @@ TRACE_EVENT(io_uring_fail_link, 
 * @ctx:		pointer to a ring context structure

 * @user_data:		user data associated with the request

 * @res:		result of the request

 * @cflags:		completion flags

 *

 */

TRACE_EVENT(io_uring_complete,



	TP_PROTO(void *ctx, u64 user_data, long res),

	TP_PROTO(void *ctx, u64 user_data, long res, unsigned cflags),



	TP_ARGS(ctx, user_data, res),

	TP_ARGS(ctx, user_data, res, cflags),



	TP_STRUCT__entry (

		__field(  void *,	ctx		)

		__field(  u64,		user_data	)

		__field(  long,		res		)

		__field(  unsigned,	cflags		)

	),



	TP_fast_assign(

		__entry->ctx		= ctx;

		__entry->user_data	= user_data;

		__entry->res		= res;

		__entry->cflags		= cflags;

	),



	TP_printk("ring %p, user_data 0x%llx, result %ld",

	TP_printk("ring %p, user_data 0x%llx, result %ld, cflags %x",

			  __entry->ctx, (unsigned long long)__entry->user_data,

			  __entry->res)

			  __entry->res, __entry->cflags)

);