Commit 7466886b authored May 02, 2022 by Miguel Ojeda Committed by Shuah Khan May 16, 2022

kunit: take `kunit_assert` as `const`



The `kunit_do_failed_assertion` function passes its
`struct kunit_assert` argument to `kunit_fail`. This one,
in turn, calls its `format` field passing the assert again
as a `const` pointer.

Therefore, the whole chain may be made `const`.

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

parent 0453f984

include/kunit/test.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -508,7 +508,7 @@ void __printf(2, 3) kunit_log_append(char log, const char fmt, ...);
		void kunit_do_failed_assertion(struct kunit *test,
		const struct kunit_loc *loc,
		enum kunit_assert_type type,
		struct kunit_assert *assert,
		const struct kunit_assert *assert,
		const char *fmt, ...);

		#define KUNIT_ASSERTION(test, assert_type, pass, assert_class, INITIALIZER, fmt, ...) do { \

lib/kunit/test.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -244,7 +244,7 @@ static void kunit_print_string_stream(struct kunit *test,
		}

		static void kunit_fail(struct kunit test, const struct kunit_loc loc,
		enum kunit_assert_type type, struct kunit_assert *assert,
		enum kunit_assert_type type, const struct kunit_assert *assert,
		const struct va_format *message)
		{
		struct string_stream *stream;
		@@ -284,7 +284,7 @@ static void __noreturn kunit_abort(struct kunit *test)
		void kunit_do_failed_assertion(struct kunit *test,
		const struct kunit_loc *loc,
		enum kunit_assert_type type,
		struct kunit_assert *assert,
		const struct kunit_assert *assert,
		const char *fmt, ...)
		{
		va_list args;