Commit 745b475e authored Aug 12, 2021 by Robert Foss Committed by Mauro Carvalho Chehab Sep 30, 2021

media: camss: vfe: Don't call hw_version() before its dependencies are met



vfe->ops->hw_version(vfe) is being called before vfe->base has been
assigned, and before the hardware has been powered up.

Fixes: b10b5334528a9 ("media: camss: vfe: Don't read hardware version needlessly")
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 936c7daa

drivers/media/platform/qcom/camss/camss-vfe.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -604,6 +604,8 @@ static int vfe_get(struct vfe_device *vfe)
		vfe_reset_output_maps(vfe);

		vfe_init_outputs(vfe);

		vfe->ops->hw_version(vfe);
		} else {
		ret = vfe_check_clock_rates(vfe);
		if (ret < 0)
		@@ -1299,7 +1301,6 @@ int msm_vfe_subdev_init(struct camss camss, struct vfe_device vfe,
		return -EINVAL;
		}
		vfe->ops->subdev_init(dev, vfe);
		vfe->ops->hw_version(vfe);

		/* Memory */