Commit 743ed81e authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Andrew Morton
Browse files

buffer: use b_folio in end_buffer_async_write() 

Save 76 bytes from avoiding the call to compound_head() in SetPageError().
Also avoid the call to compound_head() in end_page_writeback().

Link: https://lkml.kernel.org/r/20221215214402.3522366-6-willy@infradead.org


Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 2e2dba15

fs/buffer.c

+5 −5
Original line number Diff line number Diff line
@@ -344,21 +344,21 @@ void end_buffer_async_write(struct buffer_head *bh, int uptodate) 
	unsigned long flags;

	struct buffer_head *first;

	struct buffer_head *tmp;

	struct page *page;

	struct folio *folio;



	BUG_ON(!buffer_async_write(bh));



	page = bh->b_page;

	folio = bh->b_folio;

	if (uptodate) {

		set_buffer_uptodate(bh);

	} else {

		buffer_io_error(bh, ", lost async page write");

		mark_buffer_write_io_error(bh);

		clear_buffer_uptodate(bh);

		SetPageError(page);

		folio_set_error(folio);

	}



	first = page_buffers(page);

	first = folio_buffers(folio);

	spin_lock_irqsave(&first->b_uptodate_lock, flags);



	clear_buffer_async_write(bh);
@@ -372,7 +372,7 @@ void end_buffer_async_write(struct buffer_head *bh, int uptodate) 
		tmp = tmp->b_this_page;

	}

	spin_unlock_irqrestore(&first->b_uptodate_lock, flags);

	end_page_writeback(page);

	folio_end_writeback(folio);

	return;



still_busy: