Commit 7410c2d0 authored by Gal Pressman's avatar Gal Pressman Committed by Jason Gunthorpe
Browse files

RDMA/efa: Use strscpy instead of strlcpy 

The strlcpy function doesn't limit the source length, use the preferred
strscpy function instead.

Link: https://lore.kernel.org/r/20210329120131.18793-1-galpress@amazon.com


Reviewed-by: default avatarFiras JahJah <firasj@amazon.com>
Reviewed-by: default avatarYossi Leybovich <sleybo@amazon.com>
Signed-off-by: default avatarGal Pressman <galpress@amazon.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent adb76a52

drivers/infiniband/hw/efa/efa_main.c

+5 −5
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause

/*

 * Copyright 2018-2020 Amazon.com, Inc. or its affiliates. All rights reserved.

 * Copyright 2018-2021 Amazon.com, Inc. or its affiliates. All rights reserved.

 */



#include <linux/module.h>
@@ -209,11 +209,11 @@ static void efa_set_host_info(struct efa_dev *dev) 
	if (!hinf)

		return;



	strlcpy(hinf->os_dist_str, utsname()->release,

		min(sizeof(hinf->os_dist_str), sizeof(utsname()->release)));

	strscpy(hinf->os_dist_str, utsname()->release,

		sizeof(hinf->os_dist_str));

	hinf->os_type = EFA_ADMIN_OS_LINUX;

	strlcpy(hinf->kernel_ver_str, utsname()->version,

		min(sizeof(hinf->kernel_ver_str), sizeof(utsname()->version)));

	strscpy(hinf->kernel_ver_str, utsname()->version,

		sizeof(hinf->kernel_ver_str));

	hinf->kernel_ver = LINUX_VERSION_CODE;

	EFA_SET(&hinf->driver_ver, EFA_ADMIN_HOST_INFO_DRIVER_MAJOR, 0);

	EFA_SET(&hinf->driver_ver, EFA_ADMIN_HOST_INFO_DRIVER_MINOR, 0);