Commit 74003fc4 authored Jul 05, 2022 by Steven Rostedt (Google)

scsi: qla2xxx: tracing: Use the new __vstring() helper

Instead of open coding a __dynamic_array() with a fixed length (which
defeats the purpose of the dynamic array in the first place). Use the new
__vstring() helper that will use a va_list and only write enough of the
string into the ring buffer that is needed.

Link: https://lkml.kernel.org/r/20220705224750.896553364@goodmis.org



Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

parent 5409b805

include/trace/events/qla.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -22,11 +22,11 @@ DECLARE_EVENT_CLASS(qla_log_event,

		TP_STRUCT__entry(
		__string(buf, buf)
		__dynamic_array(char, msg, QLA_MSG_MAX)
		__vstring(msg, vaf->fmt, vaf->va)
		),
		TP_fast_assign(
		__assign_str(buf, buf);
		vsnprintf(__get_str(msg), QLA_MSG_MAX, vaf->fmt, *vaf->va);
		__assign_vstr(msg, vaf->fmt, vaf->va);
		),

		TP_printk("%s %s", __get_str(buf), __get_str(msg))