Commit 73eb5507 authored by Niklas Cassel's avatar Niklas Cassel Committed by Damien Le Moal
Browse files

ata: remove unused helper ata_id_flush_enabled() 



Not only is this function unused, but even worse, the bit it is checking
is actually used for signaling if the feature is supported, not enabled.
Therefore, remove the unused helper function ata_id_flush_enabled().

ata_id_has_flush() is left unmodified, since this extra supported bit
(Bit 12 of word 86) is simply a copy of the bit that ata_id_has_flush()
already checks (Bit 12 of word 83), see ACS-5 r10:
7.13.6.41 Words 85..87, 120: Commands and feature sets supported or enabled

Signed-off-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent 67776a9e

include/linux/ata.h

+0 −9
Original line number Diff line number Diff line
@@ -615,15 +615,6 @@ static inline bool ata_id_has_flush(const u16 *id) 
	return id[ATA_ID_COMMAND_SET_2] & (1 << 12);

}



static inline bool ata_id_flush_enabled(const u16 *id)

{

	if (ata_id_has_flush(id) == 0)

		return false;

	if ((id[ATA_ID_CSF_DEFAULT] & 0xC000) != 0x4000)

		return false;

	return id[ATA_ID_CFS_ENABLE_2] & (1 << 12);

}



static inline bool ata_id_has_flush_ext(const u16 *id)

{

	if ((id[ATA_ID_COMMAND_SET_2] & 0xC000) != 0x4000)