Commit 73da9cac authored by Alex Elder's avatar Alex Elder Committed by Paolo Abeni
Browse files

net: ipa: check table memory regions earlier 



Verify that the sizes of the routing and filter table memory regions
are valid as part of memory initialization, rather than waiting for
table initialization.  The main reason to do this is that upcoming
patches use these memory region sizes to determine the number of
entries in these tables, and we'll want to know these sizes are good
sooner.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 39ad8152

drivers/net/ipa/ipa_mem.c

+6 −0
Original line number Diff line number Diff line
@@ -617,6 +617,12 @@ int ipa_mem_init(struct ipa *ipa, const struct ipa_mem_data *mem_data) 
	ipa->mem_count = mem_data->local_count;

	ipa->mem = mem_data->local;



	/* Check the route and filter table memory regions */

	if (!ipa_table_mem_valid(ipa, 0))

		return -EINVAL;

	if (!ipa_table_mem_valid(ipa, IPA_ROUTE_MODEM_COUNT))

		return -EINVAL;



	ret = dma_set_mask_and_coherent(&ipa->pdev->dev, DMA_BIT_MASK(64));

	if (ret) {

		dev_err(dev, "error %d setting DMA mask\n", ret);

drivers/net/ipa/ipa_table.c

+1 −6
Original line number Diff line number Diff line
@@ -567,7 +567,7 @@ void ipa_table_config(struct ipa *ipa) 
}



/* Zero modem_route_count means filter table memory check */

static bool ipa_table_mem_valid(struct ipa *ipa, bool modem_route_count)

bool ipa_table_mem_valid(struct ipa *ipa, bool modem_route_count)

{

	bool hash_support = ipa_table_hash_support(ipa);

	bool filter = !modem_route_count;
@@ -688,11 +688,6 @@ int ipa_table_init(struct ipa *ipa) 


	ipa_table_validate_build();



	if (!ipa_table_mem_valid(ipa, 0))

		return -EINVAL;

	if (!ipa_table_mem_valid(ipa, IPA_ROUTE_MODEM_COUNT))

		return -EINVAL;



	/* The IPA hardware requires route and filter table rules to be

	 * aligned on a 128-byte boundary.  We put the "zero rule" at the

	 * base of the table area allocated here.  The DMA address returned

drivers/net/ipa/ipa_table.h

+7 −0
Original line number Diff line number Diff line
@@ -78,4 +78,11 @@ int ipa_table_init(struct ipa *ipa); 
 */

void ipa_table_exit(struct ipa *ipa);



/**

 * ipa_table_mem_valid() - Validate sizes of table memory regions

 * @ipa:	IPA pointer

 * @modem_route_count:	Number of modem route table entries

 */

bool ipa_table_mem_valid(struct ipa *ipa, bool modem_route_count);



#endif /* _IPA_TABLE_H_ */