Commit 73b6924c authored by Yang Yingliang's avatar Yang Yingliang Committed by Joerg Roedel
Browse files

iommu/mediatek: Check return value after calling platform_get_resource() 



platform_get_resource() may return NULL pointer, we need check its
return value to avoid null-ptr-deref in resource_size().

Fixes: 42d57fc5 ("iommu/mediatek: Initialise/Remove for multi bank dev")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
Link: https://lore.kernel.org/r/20221029103550.3774365-1-yangyingliang@huawei.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 30a0b95b

drivers/iommu/mtk_iommu.c

+2 −0
Original line number Diff line number Diff line
@@ -1173,6 +1173,8 @@ static int mtk_iommu_probe(struct platform_device *pdev) 


	banks_num = data->plat_data->banks_num;

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!res)

		return -EINVAL;

	if (resource_size(res) < banks_num * MTK_IOMMU_BANK_SZ) {

		dev_err(dev, "banknr %d. res %pR is not enough.\n", banks_num, res);

		return -EINVAL;