Unverified Commit 73acfba7 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

ASoC: amd: Fix error pointer dereference 



The "gpio_pa" pointer is an error pointer, there is no need to try
put it.  Calling gpiod_put() on it will lead to an error pointer
dereference.

Fixes: 02527c3f ("ASoC: amd: add Machine driver for Jadeite platform")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Ys2IRPHWGIwuVs21@kili


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4e90651e

sound/soc/amd/acp-es8336.c

+0 −1
Original line number Diff line number Diff line
@@ -212,7 +212,6 @@ static int st_es8336_late_probe(struct snd_soc_card *card) 
	if (IS_ERR(gpio_pa)) {

		ret = dev_err_probe(card->dev, PTR_ERR(gpio_pa),

				    "could not get pa-enable GPIO\n");

		gpiod_put(gpio_pa);

		put_device(codec_dev);

		return ret;

	}