Commit 7398a36c authored Oct 08, 2024 by Yihang Li Committed by xia-bing1 Nov 29, 2024

scsi: hisi_sas: Reset PHY again if phyup timeout

driver inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IB5FF2


CVE: NA

---------------------------------------------------------------------

In commit 89954f02 ("scsi: hisi_sas: Ensure all enabled PHYs up
during controller reset"), we enable PHYs in parallel through async
operations and wait for PHYs come up. However, for some directly
attached SATA disks, the PHY not come up after a timeout period and the
hardware is not ready.  At this time, we should get the latest PHY
hardware state, if the new PHY state is not ready but the old PHY state
is ready, call work HISI_PHYE_LINK_RESET to give it another chance to
phyup.

Fixes: 89954f02 ("scsi: hisi_sas: Ensure all enabled PHYs up during controller reset")
Signed-off-by: Yihang Li <liyihang9@huawei.com>
Link: https://lore.kernel.org/r/20241008021822.2617339-6-liyihang9@huawei.com


Reviewed-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Bing Xia <xiabing12@h-partners.com>

parent 2feb38ea

drivers/scsi/hisi_sas/hisi_sas_main.c

+12 −1

Original line number	Diff line number	Diff line
		@@ -1383,6 +1383,7 @@ static void hisi_sas_refresh_port_id(struct hisi_hba *hisi_hba)

		static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 state)
		{
		u32 new_state = hisi_hba->hw->get_phys_state(hisi_hba);
		struct asd_sas_port *_sas_port = NULL;
		int phy_no;

		@@ -1396,7 +1397,7 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 state)
		continue;

		/* Report PHY state change to libsas */
		if (state & BIT(phy_no)) {
		if (new_state & BIT(phy_no)) {
		if (do_port_check && sas_port && sas_port->port_dev) {
		struct domain_device *dev = sas_port->port_dev;

		@@ -1409,6 +1410,16 @@ static void hisi_sas_rescan_topology(struct hisi_hba *hisi_hba, u32 state)
		}
		} else {
		hisi_sas_phy_down(hisi_hba, phy_no, 0, GFP_KERNEL);

		/*
		* The new_state is not ready but old_state is ready,
		* the two possible causes:
		* 1. The connected device is removed
		* 2. Device exists but phyup timed out
		*/
		if (state & BIT(phy_no))
		hisi_sas_notify_phy_event(phy,
		HISI_PHYE_LINK_RESET);
		}
		}
		}