Commit 736eedc9 authored by Catalin Marinas's avatar Catalin Marinas Committed by Will Deacon
Browse files

arm64: mte: Fix double-freeing of the temporary tag storage during coredump 



Commit 16decce2 ("arm64: mte: Fix the stack frame size warning in
mte_dump_tag_range()") moved the temporary tag storage array from the
stack to slab but it also introduced an error in double freeing this
object. Remove the in-loop freeing.

Fixes: 16decce2 ("arm64: mte: Fix the stack frame size warning in mte_dump_tag_range()")
Cc: <stable@vger.kernel.org> # 5.18.x
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Reported-by: default avatarSeth Jenkins <sethjenkins@google.com>
Cc: Will Deacon <will@kernel.org>
Link: https://lore.kernel.org/r/20221222181251.1345752-2-catalin.marinas@arm.com


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent eb9a8526

arch/arm64/kernel/elfcore.c

+0 −1
Original line number Diff line number Diff line
@@ -65,7 +65,6 @@ static int mte_dump_tag_range(struct coredump_params *cprm, 
		mte_save_page_tags(page_address(page), tags);

		put_page(page);

		if (!dump_emit(cprm, tags, MTE_PAGE_TAG_STORAGE)) {

			mte_free_tag_storage(tags);

			ret = 0;

			break;

		}