Commit 736a8ccc authored by Miaohe Lin's avatar Miaohe Lin Committed by Andrew Morton
Browse files

hugetlb_cgroup: remove unneeded return value 

The return value of set_hugetlb_cgroup and set_hugetlb_cgroup_rsvd are
always ignored. Remove them to clean up the code.

Link: https://lkml.kernel.org/r/20220729080106.12752-4-linmiaohe@huawei.com


Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Reviewed-by: default avatarMike Kravetz <mike.kravetz@oracle.com>
Cc: Mina Almasry <almasrymina@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent abfb09e2

include/linux/hugetlb_cgroup.h

+8 −11
Original line number Diff line number Diff line
@@ -90,32 +90,31 @@ hugetlb_cgroup_from_page_rsvd(struct page *page) 
	return __hugetlb_cgroup_from_page(page, true);

}



static inline int __set_hugetlb_cgroup(struct page *page,

static inline void __set_hugetlb_cgroup(struct page *page,

				       struct hugetlb_cgroup *h_cg, bool rsvd)

{

	VM_BUG_ON_PAGE(!PageHuge(page), page);



	if (compound_order(page) < HUGETLB_CGROUP_MIN_ORDER)

		return -1;

		return;

	if (rsvd)

		set_page_private(page + SUBPAGE_INDEX_CGROUP_RSVD,

				 (unsigned long)h_cg);

	else

		set_page_private(page + SUBPAGE_INDEX_CGROUP,

				 (unsigned long)h_cg);

	return 0;

}



static inline int set_hugetlb_cgroup(struct page *page,

static inline void set_hugetlb_cgroup(struct page *page,

				     struct hugetlb_cgroup *h_cg)

{

	return __set_hugetlb_cgroup(page, h_cg, false);

	__set_hugetlb_cgroup(page, h_cg, false);

}



static inline int set_hugetlb_cgroup_rsvd(struct page *page,

static inline void set_hugetlb_cgroup_rsvd(struct page *page,

					  struct hugetlb_cgroup *h_cg)

{

	return __set_hugetlb_cgroup(page, h_cg, true);

	__set_hugetlb_cgroup(page, h_cg, true);

}



static inline bool hugetlb_cgroup_disabled(void)
@@ -199,16 +198,14 @@ hugetlb_cgroup_from_page_rsvd(struct page *page) 
	return NULL;

}



static inline int set_hugetlb_cgroup(struct page *page,

static inline void set_hugetlb_cgroup(struct page *page,

				     struct hugetlb_cgroup *h_cg)

{

	return 0;

}



static inline int set_hugetlb_cgroup_rsvd(struct page *page,

static inline void set_hugetlb_cgroup_rsvd(struct page *page,

					  struct hugetlb_cgroup *h_cg)

{

	return 0;

}



static inline bool hugetlb_cgroup_disabled(void)