Commit 73597bdd authored by Adheer Chandravanshi's avatar Adheer Chandravanshi Committed by Christoph Hellwig
Browse files

qla4xxx: Fix smatch warning in func qla4xxx_get_ep_param 



Fix following smatch warning:-
 drivers/scsi/qla4xxx/ql4_os.c:1752 qla4xxx_get_ep_param() warn: variable dereferenced before check 'qla_ep' (see line 1745)

Signed-off-by: default avatarVikas Chaudhary <vikas.chaudhary@qlogic.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent f65241e7

drivers/scsi/qla4xxx/ql4_os.c

+3 −3
Original line number Diff line number Diff line
@@ -1742,6 +1742,9 @@ static int qla4xxx_get_ep_param(struct iscsi_endpoint *ep, 
	struct sockaddr *dst_addr;

	struct scsi_qla_host *ha;



	if (!qla_ep)

		return -ENOTCONN;



	ha = to_qla_host(qla_ep->host);

	DEBUG2(ql4_printk(KERN_INFO, ha, "%s: host: %ld\n", __func__,

			  ha->host_no));
@@ -1749,9 +1752,6 @@ static int qla4xxx_get_ep_param(struct iscsi_endpoint *ep, 
	switch (param) {

	case ISCSI_PARAM_CONN_PORT:

	case ISCSI_PARAM_CONN_ADDRESS:

		if (!qla_ep)

			return -ENOTCONN;



		dst_addr = (struct sockaddr *)&qla_ep->dst_addr;

		if (!dst_addr)

			return -ENOTCONN;