Commit 734387ec authored by Hao Jia's avatar Hao Jia Committed by Peter Zijlstra
Browse files

sched/deadline: Remove superfluous rq clock update in push_dl_task() 



The change to call update_rq_clock() before activate_task()
commit 840d7196 ("sched/deadline: Update rq_clock of later_rq
when pushing a task") is no longer needed since commit f4904815
("sched/deadline: Fix double accounting of rq/running bw in push & pull")
removed the add_running_bw() before the activate_task().

So we remove some comments that are no longer needed and update
rq clock in activate_task().

Signed-off-by: default avatarHao Jia <jiahao.os@bytedance.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarDietmar Eggemann <dietmar.eggemann@arm.com>
Reviewed-by: default avatarDaniel Bristot de Oliveira <bristot@redhat.com>
Link: https://lore.kernel.org/r/20220430085843.62939-3-jiahao.os@bytedance.com
parent 2679a837

kernel/sched/deadline.c

+1 −7
Original line number Diff line number Diff line
@@ -2318,13 +2318,7 @@ static int push_dl_task(struct rq *rq) 


	deactivate_task(rq, next_task, 0);

	set_task_cpu(next_task, later_rq->cpu);



	/*

	 * Update the later_rq clock here, because the clock is used

	 * by the cpufreq_update_util() inside __add_running_bw().

	 */

	update_rq_clock(later_rq);

	activate_task(later_rq, next_task, ENQUEUE_NOCLOCK);

	activate_task(later_rq, next_task, 0);

	ret = 1;



	resched_curr(later_rq);