Commit 733d4bbf authored Nov 15, 2022 by Leon Romanovsky Committed by David S. Miller Nov 18, 2022

net: liquidio: simplify if expression



Fix the warning reported by kbuild:

cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/cavium/liquidio/lio_main.c:1797:54-56: WARNING !A || A && B is equivalent to !A || B
   drivers/net/ethernet/cavium/liquidio/lio_main.c:1827:54-56: WARNING !A || A && B is equivalent to !A || B

Fixes: 8979f428 ("net: liquidio: release resources when liquidio driver open failed")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Saeed Mahameed <saeed@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 11b64a46

drivers/net/ethernet/cavium/liquidio/lio_main.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1794,7 +1794,7 @@ static int liquidio_open(struct net_device *netdev)

		ifstate_set(lio, LIO_IFSTATE_RUNNING);

		if (!OCTEON_CN23XX_PF(oct) \|\| (OCTEON_CN23XX_PF(oct) && !oct->msix_on)) {
		if (!OCTEON_CN23XX_PF(oct) \|\| !oct->msix_on) {
		ret = setup_tx_poll_fn(netdev);
		if (ret)
		goto err_poll;
		@@ -1824,7 +1824,7 @@ static int liquidio_open(struct net_device *netdev)
		return 0;

		err_rx_ctrl:
		if (!OCTEON_CN23XX_PF(oct) \|\| (OCTEON_CN23XX_PF(oct) && !oct->msix_on))
		if (!OCTEON_CN23XX_PF(oct) \|\| !oct->msix_on)
		cleanup_tx_poll_fn(netdev);
		err_poll:
		if (lio->ptp_clock) {