Commit 73318c4b authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

ipv4: Fix a data-race around sysctl_fib_sync_mem. 



While reading sysctl_fib_sync_mem, it can be changed concurrently.
So, we need to add READ_ONCE() to avoid a data-race.

Fixes: 9ab948a9 ("ipv4: Allow amount of dirty memory from fib resizing to be controllable")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 48d7ee32

net/ipv4/fib_trie.c

+1 −1
Original line number Diff line number Diff line
@@ -498,7 +498,7 @@ static void tnode_free(struct key_vector *tn) 
		tn = container_of(head, struct tnode, rcu)->kv;

	}



	if (tnode_free_size >= sysctl_fib_sync_mem) {

	if (tnode_free_size >= READ_ONCE(sysctl_fib_sync_mem)) {

		tnode_free_size = 0;

		synchronize_rcu();

	}