Commit 73274c33 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jeffrey Hugo
Browse files

accel/qaic: Fix a leak in map_user_pages() 



If get_user_pages_fast() allocates some pages but not as many as we
wanted, then the current code leaks those pages.  Call put_page() on
the pages before returning.

Fixes: 129776ac ("accel/qaic: Add control path")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarPranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
Reviewed-by: default avatarJeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: default avatarDafna Hirschfeld <dhirschfeld@habana.ai>
Cc: stable@vger.kernel.org # 6.4.x
Signed-off-by: default avatarJeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://patchwork.freedesktop.org/patch/msgid/ZK0Q+ZuONTsBG+1T@moroto
parent 47d87f71

drivers/accel/qaic/qaic_control.c

+5 −2
Original line number Diff line number Diff line
@@ -419,9 +419,12 @@ static int find_and_map_user_pages(struct qaic_device *qdev, 
	}



	ret = get_user_pages_fast(xfer_start_addr, nr_pages, 0, page_list);

	if (ret < 0 || ret != nr_pages) {

		ret = -EFAULT;

	if (ret < 0)

		goto free_page_list;

	if (ret != nr_pages) {

		nr_pages = ret;

		ret = -EFAULT;

		goto put_pages;

	}



	sgt = kmalloc(sizeof(*sgt), GFP_KERNEL);