Commit 730dbb8d authored by Steven Rostedt (Google)'s avatar Steven Rostedt (Google)
Browse files

USB: mtu3: tracing: Use the new __vstring() helper 

Instead of open coding a __dynamic_array() with a fixed length (which
defeats the purpose of the dynamic array in the first place). Use the new
__vstring() helper that will use a va_list and only write enough of the
string into the ring buffer that is needed.

Link: https://lkml.kernel.org/r/20220719112719.17e796c6@gandalf.local.home



Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-usb@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Acked-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tested-by: default avatarChunfeng Yun <chunfeng.yun@mediatek.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent f71f3ba9

drivers/usb/mtu3/mtu3_trace.h

+2 −4
Original line number Original line Diff line number Diff line
@@ -18,18 +18,16 @@ 




#include "mtu3.h"

#include "mtu3.h"





#define MTU3_MSG_MAX	256



TRACE_EVENT(mtu3_log,

TRACE_EVENT(mtu3_log,

	TP_PROTO(struct device *dev, struct va_format *vaf),

	TP_PROTO(struct device *dev, struct va_format *vaf),

	TP_ARGS(dev, vaf),

	TP_ARGS(dev, vaf),

	TP_STRUCT__entry(

	TP_STRUCT__entry(

		__string(name, dev_name(dev))

		__string(name, dev_name(dev))

		__dynamic_array(char, msg, MTU3_MSG_MAX)

		__vstring(msg, vaf->fmt, vaf->va)

	),

	),

	TP_fast_assign(

	TP_fast_assign(

		__assign_str(name, dev_name(dev));

		__assign_str(name, dev_name(dev));

		vsnprintf(__get_str(msg), MTU3_MSG_MAX, vaf->fmt, *vaf->va);

		__assign_vstr(msg, vaf->fmt, vaf->va);

	),

	),

	TP_printk("%s: %s", __get_str(name), __get_str(msg))

	TP_printk("%s: %s", __get_str(name), __get_str(msg))

);

);