Commit 72fa559b authored by Ivo van Doorn's avatar Ivo van Doorn Committed by John W. Linville
Browse files

rt2x00: Make rt2x00leds_register return void 



rt2x00dev isn't interested in the rt2x00leds_register() value
anyway. So lets make it return void to even prevent people from
assuming there is anybody interested in the returnvalue.

Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 72810379

drivers/net/wireless/rt2x00/rt2x00leds.c

+3 −4
Original line number Diff line number Diff line
@@ -109,7 +109,7 @@ static int rt2x00leds_register_led(struct rt2x00_dev *rt2x00dev, 
	return 0;

}



int rt2x00leds_register(struct rt2x00_dev *rt2x00dev)

void rt2x00leds_register(struct rt2x00_dev *rt2x00dev)

{

	char *trigger;

	char dev_name[16];
@@ -117,7 +117,7 @@ int rt2x00leds_register(struct rt2x00_dev *rt2x00dev) 
	int retval;



	if (!rt2x00dev->ops->lib->led_brightness)

		return 0;

		return;



	snprintf(dev_name, sizeof(dev_name), "%s-%s",

		 rt2x00dev->ops->name, wiphy_name(rt2x00dev->hw->wiphy));
@@ -161,11 +161,10 @@ int rt2x00leds_register(struct rt2x00_dev *rt2x00dev) 
			goto exit_fail;

	}



	return 0;

	return;



exit_fail:

	rt2x00leds_unregister(rt2x00dev);

	return retval;

}



static void rt2x00leds_unregister_trigger(struct rt2x00_trigger *trigger)

drivers/net/wireless/rt2x00/rt2x00lib.h

+2 −3
Original line number Diff line number Diff line
@@ -189,7 +189,7 @@ static inline void rt2x00rfkill_free(struct rt2x00_dev *rt2x00dev) 
 */

#ifdef CONFIG_RT2X00_LIB_LEDS

void rt2x00leds_led_quality(struct rt2x00_dev *rt2x00dev, int rssi);

int rt2x00leds_register(struct rt2x00_dev *rt2x00dev);

void rt2x00leds_register(struct rt2x00_dev *rt2x00dev);

void rt2x00leds_unregister(struct rt2x00_dev *rt2x00dev);

void rt2x00leds_suspend(struct rt2x00_dev *rt2x00dev);

void rt2x00leds_resume(struct rt2x00_dev *rt2x00dev);
@@ -199,9 +199,8 @@ static inline void rt2x00leds_led_quality(struct rt2x00_dev *rt2x00dev, 
{

}



static inline int rt2x00leds_register(struct rt2x00_dev *rt2x00dev)

static inline void rt2x00leds_register(struct rt2x00_dev *rt2x00dev)

{

	return 0;

}



static inline void rt2x00leds_unregister(struct rt2x00_dev *rt2x00dev)