Commit 72cb1d7f authored by Mathieu Desnoyers's avatar Mathieu Desnoyers Committed by Peter Zijlstra
Browse files

selftests/rseq: Remove RSEQ_SKIP_FASTPATH code 



This code is not currently build by the test Makefile, adds complexity,
and is not overall useful considering that the abort handling loops to
retry the fast-path.

Signed-off-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20221122203932.231377-10-mathieu.desnoyers@efficios.com
parent f7b01bb0

tools/testing/selftests/rseq/param_test.c

+0 −4
Original line number Diff line number Diff line
@@ -38,11 +38,7 @@ static int opt_yield, opt_signal, opt_sleep, 
		opt_disable_rseq, opt_threads = 200,

		opt_disable_mod = 0, opt_test = 's', opt_mb = 0;



#ifndef RSEQ_SKIP_FASTPATH

static long long opt_reps = 5000;

#else

static long long opt_reps = 100;

#endif



static __thread __attribute__((tls_model("initial-exec")))

unsigned int signals_delivered;

tools/testing/selftests/rseq/rseq-arm.h

+0 −6
Original line number Diff line number Diff line
@@ -79,10 +79,6 @@ do { \ 
	RSEQ_WRITE_ONCE(*p, v);						\

} while (0)



#ifdef RSEQ_SKIP_FASTPATH

#include "rseq-skip.h"

#else /* !RSEQ_SKIP_FASTPATH */



#define __RSEQ_ASM_DEFINE_TABLE(label, version, flags, start_ip,	\

				post_commit_offset, abort_ip)		\

		".pushsection __rseq_cs, \"aw\"\n\t"			\
@@ -823,5 +819,3 @@ int rseq_cmpeqv_trymemcpy_storev_release(intptr_t *v, intptr_t expect, 
	rseq_bug("expected value comparison failed");

#endif

}
 


#endif /* !RSEQ_SKIP_FASTPATH */

tools/testing/selftests/rseq/rseq-arm64.h

+0 −6
Original line number Diff line number Diff line
@@ -85,10 +85,6 @@ do { \ 
	}									\

} while (0)



#ifdef RSEQ_SKIP_FASTPATH

#include "rseq-skip.h"

#else /* !RSEQ_SKIP_FASTPATH */



#define RSEQ_ASM_TMP_REG32	"w15"

#define RSEQ_ASM_TMP_REG	"x15"

#define RSEQ_ASM_TMP_REG_2	"x14"
@@ -691,5 +687,3 @@ int rseq_cmpeqv_trymemcpy_storev_release(intptr_t *v, intptr_t expect, 
	rseq_bug("expected value comparison failed");

#endif

}
 


#endif /* !RSEQ_SKIP_FASTPATH */

tools/testing/selftests/rseq/rseq-mips.h

+0 −6
Original line number Diff line number Diff line
@@ -60,10 +60,6 @@ do { \ 
	RSEQ_WRITE_ONCE(*p, v);						\

} while (0)



#ifdef RSEQ_SKIP_FASTPATH

#include "rseq-skip.h"

#else /* !RSEQ_SKIP_FASTPATH */



#if _MIPS_SZLONG == 64

# define LONG			".dword"

# define LONG_LA		"dla"
@@ -773,5 +769,3 @@ int rseq_cmpeqv_trymemcpy_storev_release(intptr_t *v, intptr_t expect, 
	rseq_bug("expected value comparison failed");

#endif

}
 


#endif /* !RSEQ_SKIP_FASTPATH */

tools/testing/selftests/rseq/rseq-ppc.h

+0 −6
Original line number Diff line number Diff line
@@ -36,10 +36,6 @@ do { \ 
	RSEQ_WRITE_ONCE(*p, v);						\

} while (0)



#ifdef RSEQ_SKIP_FASTPATH

#include "rseq-skip.h"

#else /* !RSEQ_SKIP_FASTPATH */



/*

 * The __rseq_cs_ptr_array and __rseq_cs sections can be used by debuggers to

 * better handle single-stepping through the restartable critical sections.
@@ -787,5 +783,3 @@ int rseq_cmpeqv_trymemcpy_storev_release(intptr_t *v, intptr_t expect, 
	rseq_bug("expected value comparison failed");

#endif

}
 


#endif /* !RSEQ_SKIP_FASTPATH */