Commit 72ba4505 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jonathan Cameron
Browse files

iio: dac: ad5592r: Make ad5592r_remove() return void 



Up to now ad5592r_remove() returns zero unconditionally. Make it return
void instead which makes it easier to see in the callers that there is
no error to handle.

Also the return value of i2c and spi remove callbacks is ignored anyway.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarAlexandru Ardelean <ardeleanalex@gmail.com>
Link: https://lore.kernel.org/r/20211013203223.2694577-10-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 1f10848f

drivers/iio/dac/ad5592r-base.c

+1 −3
Original line number Diff line number Diff line
@@ -663,7 +663,7 @@ int ad5592r_probe(struct device *dev, const char *name, 
}

EXPORT_SYMBOL_GPL(ad5592r_probe);



int ad5592r_remove(struct device *dev)

void ad5592r_remove(struct device *dev)

{

	struct iio_dev *iio_dev = dev_get_drvdata(dev);

	struct ad5592r_state *st = iio_priv(iio_dev);
@@ -674,8 +674,6 @@ int ad5592r_remove(struct device *dev) 


	if (st->reg)

		regulator_disable(st->reg);



	return 0;

}

EXPORT_SYMBOL_GPL(ad5592r_remove);

drivers/iio/dac/ad5592r-base.h

+1 −1
Original line number Diff line number Diff line
@@ -71,6 +71,6 @@ struct ad5592r_state { 


int ad5592r_probe(struct device *dev, const char *name,

		const struct ad5592r_rw_ops *ops);

int ad5592r_remove(struct device *dev);

void ad5592r_remove(struct device *dev);



#endif /* __DRIVERS_IIO_DAC_AD5592R_BASE_H__ */

drivers/iio/dac/ad5592r.c

+3 −1
Original line number Diff line number Diff line
@@ -132,7 +132,9 @@ static int ad5592r_spi_probe(struct spi_device *spi) 


static int ad5592r_spi_remove(struct spi_device *spi)

{

	return ad5592r_remove(&spi->dev);

	ad5592r_remove(&spi->dev);



	return 0;

}



static const struct spi_device_id ad5592r_spi_ids[] = {

drivers/iio/dac/ad5593r.c

+3 −1
Original line number Diff line number Diff line
@@ -99,7 +99,9 @@ static int ad5593r_i2c_probe(struct i2c_client *i2c, 


static int ad5593r_i2c_remove(struct i2c_client *i2c)

{

	return ad5592r_remove(&i2c->dev);

	ad5592r_remove(&i2c->dev);



	return 0;

}



static const struct i2c_device_id ad5593r_i2c_ids[] = {