Commit 729d9248 authored by José Expósito's avatar José Expósito Committed by Yang Yingliang
Browse files

drm/imx: Fix memory leak in imx_pd_connector_get_modes 

stable inclusion
from stable-v4.19.238
commit 41624d7c0c3df71dee170c610744aaa5909327b8
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBP1KE
CVE: CVE-2022-49091

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=41624d7c0c3df71dee170c610744aaa5909327b8



--------------------------------

[ Upstream commit bce81feb ]

Avoid leaking the display mode variable if of_get_drm_display_mode
fails.

Fixes: 76ecd9c9 ("drm/imx: parallel-display: check return code from of_get_drm_display_mode()")
Addresses-Coverity-ID: 1443943 ("Resource leak")
Signed-off-by: default avatarJosé Expósito <jose.exposito89@gmail.com>
Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/r/20220108165230.44610-1-jose.exposito89@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
parent df354167

drivers/gpu/drm/imx/parallel-display.c

+3 −1
Original line number Diff line number Diff line
@@ -77,8 +77,10 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector) 
		ret = of_get_drm_display_mode(np, &imxpd->mode,

					      &imxpd->bus_flags,

					      OF_USE_NATIVE_MODE);

		if (ret)

		if (ret) {

			drm_mode_destroy(connector->dev, mode);

			return ret;

		}



		drm_mode_copy(mode, &imxpd->mode);

		mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,