Commit 72949f76 authored by Dan Carpenter's avatar Dan Carpenter Committed by Shawn Guo
Browse files

soc: imx: imx8m-blk-ctrl: off by one in imx8m_blk_ctrl_xlate() 



The > comparison should be >= to prevent reading one element beyond the
end of the array.  The onecell_data->domains[] array is allocated in
imx8m_blk_ctrl_probe() and it has "onecell_data->num_domains" elements.

Fixes: 5b340e7813d4 ("soc: imx: add i.MX8M blk-ctrl driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarLucas Stach <l.stach@pengutronix.de>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 926e57c0

drivers/soc/imx/imx8m-blk-ctrl.c

+1 −1
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ imx8m_blk_ctrl_xlate(struct of_phandle_args *args, void *data) 
	unsigned int index = args->args[0];



	if (args->args_count != 1 ||

	    index > onecell_data->num_domains)

	    index >= onecell_data->num_domains)

		return ERR_PTR(-EINVAL);



	return onecell_data->domains[index];