Commit 72848de0 authored by farah kassabri's avatar farah kassabri Committed by Oded Gabbay
Browse files

habanalabs: check pad and reserved fields in ioctls 



Make sure all reserved/pad fields in uapi input structures
are set to 0.

Signed-off-by: default avatarfarah kassabri <fkassabri@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 0970380a

drivers/accel/habanalabs/common/command_submission.c

+14 −1
Original line number Diff line number Diff line
@@ -1310,6 +1310,13 @@ static int hl_cs_sanity_checks(struct hl_fpriv *hpriv, union hl_cs_args *args) 
	enum hl_device_status status;

	enum hl_cs_type cs_type;

	bool is_sync_stream;

	int i;



	for (i = 0 ; i < sizeof(args->in.pad) ; i++)

		if (args->in.pad[i]) {

			dev_dbg(hdev->dev, "Padding bytes must be 0\n");

			return -EINVAL;

		}



	if (!hl_device_operational(hdev, &status)) {

		return -EBUSY;
@@ -2918,7 +2925,13 @@ static int hl_multi_cs_wait_ioctl(struct hl_fpriv *hpriv, void *data) 
	u32 size_to_copy;

	u64 *cs_seq_arr;

	u8 seq_arr_len;

	int rc;

	int rc, i;



	for (i = 0 ; i < sizeof(args->in.pad) ; i++)

		if (args->in.pad[i]) {

			dev_dbg(hdev->dev, "Padding bytes must be 0\n");

			return -EINVAL;

		}



	if (!hdev->supports_wait_for_multi_cs) {

		dev_err(hdev->dev, "Wait for multi CS is not supported\n");

drivers/accel/habanalabs/common/habanalabs_ioctl.c

+5 −1
Original line number Diff line number Diff line
@@ -884,9 +884,13 @@ static int _hl_info_ioctl(struct hl_fpriv *hpriv, void *data, 
	enum hl_device_status status;

	struct hl_info_args *args = data;

	struct hl_device *hdev = hpriv->hdev;



	int rc;



	if (args->pad) {

		dev_dbg(hdev->dev, "Padding bytes must be 0\n");

		return -EINVAL;

	}



	/*

	 * Information is returned for the following opcodes even if the device

	 * is disabled or in reset.