Commit 727de4c0 authored by Lukas Bulwahn's avatar Lukas Bulwahn Committed by Lorenzo Pieralisi
Browse files

PCI: rcar: Avoid defines prefixed with CONFIG 

Defines prefixed with "CONFIG" should be limited to proper Kconfig options,
that are introduced in a Kconfig file.

In the R-car driver the bitmask to configure the SEND_ENABLE mode is named
CONFIG_SEND_ENABLE.

Rename this local definition to a more suitable name, containing the
register bitfield name defined in the R-Car Gen3 rev. 2.30 user
manual.

No functional change.

Link: https://lore.kernel.org/r/20230113084516.31888-1-lukas.bulwahn@gmail.com


Signed-off-by: default avatarLukas Bulwahn <lukas.bulwahn@gmail.com>
[lpieralisi@kernel.org: Changed define naming and commit log]
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
parent fe15c26e

drivers/pci/controller/pcie-rcar-host.c

+2 −2
Original line number Diff line number Diff line
@@ -219,9 +219,9 @@ static int rcar_pcie_config_access(struct rcar_pcie_host *host, 


	/* Enable the configuration access */

	if (pci_is_root_bus(bus->parent))

		rcar_pci_write_reg(pcie, CONFIG_SEND_ENABLE | TYPE0, PCIECCTLR);

		rcar_pci_write_reg(pcie, PCIECCTLR_CCIE | TYPE0, PCIECCTLR);

	else

		rcar_pci_write_reg(pcie, CONFIG_SEND_ENABLE | TYPE1, PCIECCTLR);

		rcar_pci_write_reg(pcie, PCIECCTLR_CCIE | TYPE1, PCIECCTLR);



	/* Check for errors */

	if (rcar_pci_read_reg(pcie, PCIEERRFR) & UNSUPPORTED_REQUEST)

drivers/pci/controller/pcie-rcar.h

+1 −1
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ 


#define PCIECAR			0x000010

#define PCIECCTLR		0x000018

#define  CONFIG_SEND_ENABLE	BIT(31)

#define  PCIECCTLR_CCIE		BIT(31)

#define  TYPE0			(0 << 8)

#define  TYPE1			BIT(8)

#define PCIECDR			0x000020