Commit 727073ca authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: cfg80211: reject bad AP MLD address 



When trying to authenticate, if the AP MLD address isn't
a valid address, mac80211 can throw a warning. Avoid that
by rejecting such addresses.

Fixes: d648c230 ("wifi: nl80211: support MLO in auth/assoc")
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230604120651.89188912bd1d.I8dbc6c8ee0cb766138803eec59508ef4ce477709@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent c37ab22b

net/wireless/nl80211.c

+2 −0
Original line number Diff line number Diff line
@@ -10723,6 +10723,8 @@ static int nl80211_authenticate(struct sk_buff *skb, struct genl_info *info) 
		if (!info->attrs[NL80211_ATTR_MLD_ADDR])

			return -EINVAL;

		req.ap_mld_addr = nla_data(info->attrs[NL80211_ATTR_MLD_ADDR]);

		if (!is_valid_ether_addr(req.ap_mld_addr))

			return -EINVAL;

	}









	req.bss = cfg80211_get_bss(&rdev->wiphy, chan, bssid, ssid, ssid_len,