Commit 72145a68 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

tcp: md5: add LINUX_MIB_TCPMD5FAILURE counter 



Adds SNMP counter for drops caused by MD5 mismatches.

The current syslog might help, but a counter is more precise and helps
monitoring.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e65c332d

include/uapi/linux/snmp.h

+1 −0
Original line number Diff line number Diff line
@@ -235,6 +235,7 @@ enum 
	LINUX_MIB_TCPSPURIOUSRTOS,		/* TCPSpuriousRTOs */

	LINUX_MIB_TCPMD5NOTFOUND,		/* TCPMD5NotFound */

	LINUX_MIB_TCPMD5UNEXPECTED,		/* TCPMD5Unexpected */

	LINUX_MIB_TCPMD5FAILURE,		/* TCPMD5Failure */

	LINUX_MIB_SACKSHIFTED,

	LINUX_MIB_SACKMERGED,

	LINUX_MIB_SACKSHIFTFALLBACK,

net/ipv4/proc.c

+1 −0
Original line number Diff line number Diff line
@@ -257,6 +257,7 @@ static const struct snmp_mib snmp4_net_list[] = { 
	SNMP_MIB_ITEM("TCPSpuriousRTOs", LINUX_MIB_TCPSPURIOUSRTOS),

	SNMP_MIB_ITEM("TCPMD5NotFound", LINUX_MIB_TCPMD5NOTFOUND),

	SNMP_MIB_ITEM("TCPMD5Unexpected", LINUX_MIB_TCPMD5UNEXPECTED),

	SNMP_MIB_ITEM("TCPMD5Failure", LINUX_MIB_TCPMD5FAILURE),

	SNMP_MIB_ITEM("TCPSackShifted", LINUX_MIB_SACKSHIFTED),

	SNMP_MIB_ITEM("TCPSackMerged", LINUX_MIB_SACKMERGED),

	SNMP_MIB_ITEM("TCPSackShiftFallback", LINUX_MIB_SACKSHIFTFALLBACK),

net/ipv4/tcp_ipv4.c

+1 −0
Original line number Diff line number Diff line
@@ -1169,6 +1169,7 @@ static bool tcp_v4_inbound_md5_hash(const struct sock *sk, 
				      NULL, skb);



	if (genhash || memcmp(hash_location, newhash, 16) != 0) {

		NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPMD5FAILURE);

		net_info_ratelimited("MD5 Hash failed for (%pI4, %d)->(%pI4, %d)%s\n",

				     &iph->saddr, ntohs(th->source),

				     &iph->daddr, ntohs(th->dest),

net/ipv6/tcp_ipv6.c

+1 −0
Original line number Diff line number Diff line
@@ -671,6 +671,7 @@ static bool tcp_v6_inbound_md5_hash(const struct sock *sk, 
				      NULL, skb);



	if (genhash || memcmp(hash_location, newhash, 16) != 0) {

		NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPMD5FAILURE);

		net_info_ratelimited("MD5 Hash %s for [%pI6c]:%u->[%pI6c]:%u\n",

				     genhash ? "failed" : "mismatch",

				     &ip6h->saddr, ntohs(th->source),