Commit 71f964c3 authored by Lee Jones's avatar Lee Jones Committed by Jason Gunthorpe
Browse files

RDMA/hw/qib/qib_iba6120: Fix some repeated (copy/paste) kernel-doc issues 

Fixes the following W=1 kernel build warning(s):

 drivers/infiniband/hw/qib/qib_iba6120.c:1229: warning: Function parameter or member 'ppd' not described in 'qib_6120_bringup_serdes'
 drivers/infiniband/hw/qib/qib_iba6120.c:1229: warning: Excess function parameter 'dd' description in 'qib_6120_bringup_serdes'
 drivers/infiniband/hw/qib/qib_iba6120.c:1436: warning: Function parameter or member 'ppd' not described in 'qib_6120_setup_setextled'
 drivers/infiniband/hw/qib/qib_iba6120.c:1436: warning: Excess function parameter 'dd' description in 'qib_6120_setup_setextled'
 drivers/infiniband/hw/qib/qib_iba6120.c:1836: warning: Function parameter or member 'type' not described in 'qib_6120_put_tid'
 drivers/infiniband/hw/qib/qib_iba6120.c:1836: warning: Excess function parameter 'tidtype' description in 'qib_6120_put_tid'
 drivers/infiniband/hw/qib/qib_iba6120.c:1903: warning: Function parameter or member 'type' not described in 'qib_6120_put_tid_2'
 drivers/infiniband/hw/qib/qib_iba6120.c:1903: warning: Excess function parameter 'tidtype' description in 'qib_6120_put_tid_2'
 drivers/infiniband/hw/qib/qib_iba6120.c:1944: warning: Function parameter or member 'rcd' not described in 'qib_6120_clear_tids'
 drivers/infiniband/hw/qib/qib_iba6120.c:1944: warning: Excess function parameter 'ctxt' description in 'qib_6120_clear_tids'
 drivers/infiniband/hw/qib/qib_iba6120.c:2018: warning: Function parameter or member 'kinfo' not described in 'qib_6120_get_base_info'
 drivers/infiniband/hw/qib/qib_iba6120.c:2018: warning: Excess function parameter 'kbase' description in 'qib_6120_get_base_info'
 drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Function parameter or member 'ppd' not described in 'qib_portcntr_6120'
 drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Function parameter or member 'reg' not described in 'qib_portcntr_6120'
 drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Excess function parameter 'dd' description in 'qib_portcntr_6120'
 drivers/infiniband/hw/qib/qib_iba6120.c:2277: warning: Excess function parameter 'creg' description in 'qib_portcntr_6120'
 drivers/infiniband/hw/qib/qib_iba6120.c:2620: warning: Function parameter or member 't' not described in 'qib_get_6120_faststats'

Link: https://lore.kernel.org/r/20210121094519.2044049-30-lee.jones@linaro.org


Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 3c2504be

drivers/infiniband/hw/qib/qib_iba6120.c

+9 −9
Original line number Diff line number Diff line
@@ -1223,7 +1223,7 @@ static void qib_set_ib_6120_lstate(struct qib_pportdata *ppd, u16 linkcmd, 


/**

 * qib_6120_bringup_serdes - bring up the serdes

 * @dd: the qlogic_ib device

 * @ppd: the qlogic_ib device

 */

static int qib_6120_bringup_serdes(struct qib_pportdata *ppd)

{
@@ -1412,7 +1412,7 @@ static void qib_6120_quiet_serdes(struct qib_pportdata *ppd) 


/**

 * qib_6120_setup_setextled - set the state of the two external LEDs

 * @dd: the qlogic_ib device

 * @ppd: the qlogic_ib device

 * @on: whether the link is up or not

 *

 * The exact combo of LEDs if on is true is determined by looking
@@ -1823,7 +1823,7 @@ static int qib_6120_setup_reset(struct qib_devdata *dd) 
 * qib_6120_put_tid - write a TID in chip

 * @dd: the qlogic_ib device

 * @tidptr: pointer to the expected TID (in chip) to update

 * @tidtype: RCVHQ_RCV_TYPE_EAGER (1) for eager, RCVHQ_RCV_TYPE_EXPECTED (0)

 * @type: RCVHQ_RCV_TYPE_EAGER (1) for eager, RCVHQ_RCV_TYPE_EXPECTED (0)

 * for expected

 * @pa: physical address of in memory buffer; tidinvalid if freeing

 *
@@ -1890,7 +1890,7 @@ static void qib_6120_put_tid(struct qib_devdata *dd, u64 __iomem *tidptr, 
 * qib_6120_put_tid_2 - write a TID in chip, Revision 2 or higher

 * @dd: the qlogic_ib device

 * @tidptr: pointer to the expected TID (in chip) to update

 * @tidtype: RCVHQ_RCV_TYPE_EAGER (1) for eager, RCVHQ_RCV_TYPE_EXPECTED (0)

 * @type: RCVHQ_RCV_TYPE_EAGER (1) for eager, RCVHQ_RCV_TYPE_EXPECTED (0)

 * for expected

 * @pa: physical address of in memory buffer; tidinvalid if freeing

 *
@@ -1932,7 +1932,7 @@ static void qib_6120_put_tid_2(struct qib_devdata *dd, u64 __iomem *tidptr, 
/**

 * qib_6120_clear_tids - clear all TID entries for a context, expected and eager

 * @dd: the qlogic_ib device

 * @ctxt: the context

 * @rcd: the context

 *

 * clear all TID entries for a context, expected and eager.

 * Used from qib_close().  On this chip, TIDs are only 32 bits,
@@ -2008,7 +2008,7 @@ int __attribute__((weak)) qib_unordered_wc(void) 
/**

 * qib_6120_get_base_info - set chip-specific flags for user code

 * @rcd: the qlogic_ib ctxt

 * @kbase: qib_base_info pointer

 * @kinfo: qib_base_info pointer

 *

 * We set the PCIE flag because the lower bandwidth on PCIe vs

 * HyperTransport can affect some user packet algorithms.
@@ -2270,8 +2270,8 @@ static void sendctrl_6120_mod(struct qib_pportdata *ppd, u32 op) 


/**

 * qib_portcntr_6120 - read a per-port counter

 * @dd: the qlogic_ib device

 * @creg: the counter to snapshot

 * @ppd: the qlogic_ib device

 * @reg: the counter to snapshot

 */

static u64 qib_portcntr_6120(struct qib_pportdata *ppd, u32 reg)

{
@@ -2610,7 +2610,7 @@ static void qib_chk_6120_errormask(struct qib_devdata *dd) 


/**

 * qib_get_faststats - get word counters from chip before they overflow

 * @opaque - contains a pointer to the qlogic_ib device qib_devdata

 * @t: contains a pointer to the qlogic_ib device qib_devdata

 *

 * This needs more work; in particular, decision on whether we really

 * need traffic_wds done the way it is