Commit 71f1309f authored by Yue Hu's avatar Yue Hu Committed by Rafael J. Wysocki
Browse files

cpufreq: schedutil: Remove needless sg_policy parameter from ignore_dl_rate_limit() 



Since sg_policy is a member of struct sugov_cpu.

Also remove the local variable in sugov_update_single_common() to
make the code more clean.

Signed-off-by: default avatarYue Hu <huyue2@yulong.com>
Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
[ rjw: Minor subject edits ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent cbf8363e

kernel/sched/cpufreq_schedutil.c

+5 −7
Original line number Diff line number Diff line
@@ -426,23 +426,21 @@ static inline bool sugov_cpu_is_busy(struct sugov_cpu *sg_cpu) { return false; } 
 * Make sugov_should_update_freq() ignore the rate limit when DL

 * has increased the utilization.

 */

static inline void ignore_dl_rate_limit(struct sugov_cpu *sg_cpu, struct sugov_policy *sg_policy)

static inline void ignore_dl_rate_limit(struct sugov_cpu *sg_cpu)

{

	if (cpu_bw_dl(cpu_rq(sg_cpu->cpu)) > sg_cpu->bw_dl)

		sg_policy->limits_changed = true;

		sg_cpu->sg_policy->limits_changed = true;

}



static inline bool sugov_update_single_common(struct sugov_cpu *sg_cpu,

					      u64 time, unsigned int flags)

{

	struct sugov_policy *sg_policy = sg_cpu->sg_policy;



	sugov_iowait_boost(sg_cpu, time, flags);

	sg_cpu->last_update = time;



	ignore_dl_rate_limit(sg_cpu, sg_policy);

	ignore_dl_rate_limit(sg_cpu);



	if (!sugov_should_update_freq(sg_policy, time))

	if (!sugov_should_update_freq(sg_cpu->sg_policy, time))

		return false;



	sugov_get_util(sg_cpu);
@@ -557,7 +555,7 @@ sugov_update_shared(struct update_util_data *hook, u64 time, unsigned int flags) 
	sugov_iowait_boost(sg_cpu, time, flags);

	sg_cpu->last_update = time;



	ignore_dl_rate_limit(sg_cpu, sg_policy);

	ignore_dl_rate_limit(sg_cpu);



	if (sugov_should_update_freq(sg_policy, time)) {

		next_f = sugov_next_freq_shared(sg_cpu, time);