Unverified Commit 71ee2a4f authored by Chen Jiahao's avatar Chen Jiahao Committed by Mark Brown
Browse files

spi: microchip-core: Clean up redundant dev_err_probe() 



Refering to platform_get_irq()'s definition, the return value has
already been checked if ret < 0, and printed via dev_err_probe().
Calling dev_err_probe() one more time outside platform_get_irq()
is obviously redundant.

Furthermore, platform_get_irq() will never return irq equals 0,
removing spi->irq == 0 checking to clean it up.

Signed-off-by: default avatarChen Jiahao <chenjiahao16@huawei.com>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230728075729.3451867-1-chenjiahao16@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 026badeb

drivers/spi/spi-microchip-core.c

+2 −4
Original line number Diff line number Diff line
@@ -530,10 +530,8 @@ static int mchp_corespi_probe(struct platform_device *pdev) 
		return PTR_ERR(spi->regs);



	spi->irq = platform_get_irq(pdev, 0);

	if (spi->irq <= 0)

		return dev_err_probe(&pdev->dev, -ENXIO,

				     "invalid IRQ %d for SPI controller\n",

				     spi->irq);

	if (spi->irq < 0)

		return spi->irq;



	ret = devm_request_irq(&pdev->dev, spi->irq, mchp_corespi_interrupt,

			       IRQF_SHARED, dev_name(&pdev->dev), master);