Commit 71e6d060 authored by Yang Li's avatar Yang Li Committed by Mauro Carvalho Chehab
Browse files

media: platform: Remove unnecessary print function dev_err() 

The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Eliminate the follow coccicheck warnings:
./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c:119:2-9:
line 119 is redundant because platform_get_irq() already prints an error
./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c:103:2-9:
line 103 is redundant because platform_get_irq() already prints an error

Link: https://lore.kernel.org/linux-media/20220316001411.80167-1-yang.lee@linux.alibaba.com


Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 5d1ca138

drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c

+1 −3
Original line number Diff line number Diff line
@@ -115,10 +115,8 @@ static int mtk_vcodec_init_dec_resources(struct mtk_vcodec_dev *dev) 
		return 0;



	dev->dec_irq = platform_get_irq(pdev, 0);

	if (dev->dec_irq < 0) {

		dev_err(&pdev->dev, "failed to get irq number");

	if (dev->dec_irq < 0)

		return dev->dec_irq;

	}



	irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);

	ret = devm_request_irq(&pdev->dev, dev->dec_irq,

drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c

+1 −3
Original line number Diff line number Diff line
@@ -101,10 +101,8 @@ static int mtk_vdec_hw_init_irq(struct mtk_vdec_hw_dev *dev) 
	int ret;



	dev->dec_irq = platform_get_irq(pdev, 0);

	if (dev->dec_irq < 0) {

		dev_err(&pdev->dev, "Failed to get irq resource");

	if (dev->dec_irq < 0)

		return dev->dec_irq;

	}



	irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);

	ret = devm_request_irq(&pdev->dev, dev->dec_irq,