Commit 71d93eac authored Mar 31, 2023 by Lee Jones Committed by Jani Nikula Apr 03, 2023

drm/i915/gem/i915_gem_ttm_pm: Provide a couple of missing descriptions for...

drm/i915/gem/i915_gem_ttm_pm: Provide a couple of missing descriptions for 'flags' and remove some superfluous ones

Fixes the following W=1 kernel build warning(s):

drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Function parameter or member 'flags' not described in 'i915_ttm_backup_region'
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_backup_region'
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:156: warning: Excess function parameter 'backup_pinned' description in 'i915_ttm_backup_region'
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:223: warning: Function parameter or member 'flags' not described in 'i915_ttm_restore_region'
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c:223: warning: Excess function parameter 'allow_gpu' description in 'i915_ttm_restore_region'

Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230331092607.700644-10-lee@kernel.org

parent 0b81afa5

drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -144,8 +144,7 @@ void i915_ttm_recover_region(struct intel_memory_region *mr)
		/**
		* i915_ttm_backup_region - Back up all objects of a region to smem.
		* @mr: The memory region
		* @allow_gpu: Whether to allow the gpu blitter for this backup.
		* @backup_pinned: Backup also pinned objects.
		* @flags: TTM backup flags
		*
		* Loops over all objects of a region and either evicts them if they are
		* evictable or backs them up using a backup object if they are pinned.
		@@ -209,7 +208,7 @@ static int i915_ttm_restore(struct i915_gem_apply_to_region *apply,
		/**
		* i915_ttm_restore_region - Restore backed-up objects of a region from smem.
		* @mr: The memory region
		* @allow_gpu: Whether to allow the gpu blitter to recover.
		* @flags: TTM backup flags
		*
		* Loops over all objects of a region and if they are backed-up, restores
		* them from smem.