Commit 71c8f15e authored by Vaibhav Gupta's avatar Vaibhav Gupta Committed by Martin K. Petersen
Browse files

scsi: hisi_sas_v3_hw: Remove extra function calls for runtime pm 

Both runtime_suspend_v3_hw() and runtime_resume_v3_hw() do nothing else but
invoke suspend_v3_hw() and resume_v3_hw() respectively. This is the case of
unnecessary function calls. To use those functions for runtime pm as well,
simply use UNIVERSAL_DEV_PM_OPS.

make -j$(nproc) W=1, with CONFIG_PM disabled, throws '-Wunused-function'
warning for runtime_suspend_v3_hw() and runtime_resume_v3_hw(). After
dropping those function definitions, the warning was thrown for
suspend_v3_hw() and resume_v3_hw(). Hence, mark them as '__maybe_unused'.

Link: https://lore.kernel.org/r/20201102164730.324035-15-vaibhavgupta40@gmail.com


Signed-off-by: default avatarVaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 027e508a

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

+6 −17
Original line number Original line Diff line number Diff line
@@ -3502,7 +3502,7 @@ static int _resume_v3_hw(struct device *device) 
	return 0;

	return 0;

}

}





static int suspend_v3_hw(struct device *device)

static int __maybe_unused suspend_v3_hw(struct device *device)

{

{

	struct pci_dev *pdev = to_pci_dev(device);

	struct pci_dev *pdev = to_pci_dev(device);

	struct sas_ha_struct *sha = pci_get_drvdata(pdev);

	struct sas_ha_struct *sha = pci_get_drvdata(pdev);
@@ -3518,7 +3518,7 @@ static int suspend_v3_hw(struct device *device) 
	return rc;

	return rc;

}

}





static int resume_v3_hw(struct device *device)

static int __maybe_unused resume_v3_hw(struct device *device)

{

{

	struct pci_dev *pdev = to_pci_dev(device);

	struct pci_dev *pdev = to_pci_dev(device);

	struct sas_ha_struct *sha = pci_get_drvdata(pdev);

	struct sas_ha_struct *sha = pci_get_drvdata(pdev);
@@ -3541,21 +3541,10 @@ static const struct pci_error_handlers hisi_sas_err_handler = { 
	.reset_done	= hisi_sas_reset_done_v3_hw,

	.reset_done	= hisi_sas_reset_done_v3_hw,

};

};





static int runtime_suspend_v3_hw(struct device *dev)

static UNIVERSAL_DEV_PM_OPS(hisi_sas_v3_pm_ops,

{

			    suspend_v3_hw,

	return suspend_v3_hw(dev);

			    resume_v3_hw,

}

			    NULL);



static int runtime_resume_v3_hw(struct device *dev)

{

	return resume_v3_hw(dev);

}



static const struct dev_pm_ops hisi_sas_v3_pm_ops = {

	SET_SYSTEM_SLEEP_PM_OPS(suspend_v3_hw, resume_v3_hw)

	SET_RUNTIME_PM_OPS(runtime_suspend_v3_hw,

			   runtime_resume_v3_hw, NULL)

};





static struct pci_driver sas_v3_pci_driver = {

static struct pci_driver sas_v3_pci_driver = {

	.name		= DRV_NAME,

	.name		= DRV_NAME,